Mark graphql-sock peer dependency as optional in typescript/operations plugin#10330
Merged
eddeee888 merged 4 commits intodotansimha:masterfrom Apr 14, 2025
Merged
Mark graphql-sock peer dependency as optional in typescript/operations plugin#10330eddeee888 merged 4 commits intodotansimha:masterfrom
eddeee888 merged 4 commits intodotansimha:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 76d35b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Thanks @jnoordsij !
Could you please also do |
eddeee888
approved these changes
Apr 14, 2025
Collaborator
|
Thank you! |
Contributor
Author
|
Thanks for finishing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR marks the
graphql-sockpeer dependency introduced in #10323 as optional in the@graphql-codegen/typescript-operationsplugin. This will ensure it will not trigger any Yarn warning (or potentially similar warnings for other package managers).Related #10329
Type of change
Screenshots/Sandbox (if appropriate/relevant):
N/A
How Has This Been Tested?
N/A
Test Environment:
@graphql-codegen/...: @graphql-codegen/typescript-operations 4.6.0Checklist:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...